Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

From	Sudeep Holla <sudeep.holla@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"
Date	2017-03-14 17:20 +0100
Message-ID	<tkXl0-2CM-27@gated-at.bofh.it> (permalink)
References	<tgbRD-387-13@gated-at.bofh.it> <tgemt-4Vt-1@gated-at.bofh.it>
Organization	ARM

Show all headers | View raw


On 01/03/17 15:23, Aleksey Makarov wrote:
> The original patch makes the condition always true, so it is wrong.
> 
> It masks (but not fixes) the bug described in the commit message
> but introduces a regression (no console is selected by SPCR)
> in regular (no 'console=ttyAMA') case.
> 
> s/||/&&/ would not fix the problem as the root cause was identified
> incorrectly.
> 
> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
> 

Sorry for that, I will test your patches and respond to that. For this
patch:

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 17:20 +0100
  Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" "Jayachandran C." <c.jayachandran@gmail.com> - 2017-03-16 08:20 +0100
    Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" Aleksey Makarov <amakarov.linux@gmail.com> - 2017-03-16 10:40 +0100
      Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-17 06:10 +0100

csiph-web