Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

From	Aleksey Makarov <amakarov.linux@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"
Date	2017-03-16 10:40 +0100
Message-ID	<tlA2Z-4H0-7@gated-at.bofh.it> (permalink)
References	<tgbRD-387-13@gated-at.bofh.it> <tgemt-4Vt-1@gated-at.bofh.it> <tkXl0-2CM-27@gated-at.bofh.it> <tlxRw-3e8-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> Hi Greg,
> 
> On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>
>> On 01/03/17 15:23, Aleksey Makarov wrote:
>>> The original patch makes the condition always true, so it is wrong.
>>>
>>> It masks (but not fixes) the bug described in the commit message
>>> but introduces a regression (no console is selected by SPCR)
>>> in regular (no 'console=ttyAMA') case.
>>>
>>> s/||/&&/ would not fix the problem as the root cause was identified
>>> incorrectly.
>>>
>>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
>>>
>>
>> Sorry for that, I will test your patches and respond to that. For this
>> patch:
>>
>> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>>
> 
> This fixes a regression I see in v4.11-rc2
> 
> Tested-by: Jayachandran C <jnair@caviumnetworks.com>
> 
> I don't see it in the tty/serial tree yet

It's commit 713b93f1b849 from tty-next branch of 
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git

So it looks like it is scheduled for 4.12

Greg, this is a fix for regression.  Can it be applied to 4.11-rcX?

Thank you
Aleksey Makarov

> 
> JC.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Thread

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 17:20 +0100
  Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" "Jayachandran C." <c.jayachandran@gmail.com> - 2017-03-16 08:20 +0100
    Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" Aleksey Makarov <amakarov.linux@gmail.com> - 2017-03-16 10:40 +0100
      Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching  pl011 console" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-17 06:10 +0100

csiph-web