Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600659 > unrolled thread
| Started by | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| First post | 2017-03-14 17:20 +0100 |
| Last post | 2017-03-17 06:10 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" Sudeep Holla <sudeep.holla@arm.com> - 2017-03-14 17:20 +0100
Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" "Jayachandran C." <c.jayachandran@gmail.com> - 2017-03-16 08:20 +0100
Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" Aleksey Makarov <amakarov.linux@gmail.com> - 2017-03-16 10:40 +0100
Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-17 06:10 +0100
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2017-03-14 17:20 +0100 |
| Subject | Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console" |
| Message-ID | <tkXl0-2CM-27@gated-at.bofh.it> |
On 01/03/17 15:23, Aleksey Makarov wrote: > The original patch makes the condition always true, so it is wrong. > > It masks (but not fixes) the bug described in the commit message > but introduces a regression (no console is selected by SPCR) > in regular (no 'console=ttyAMA') case. > > s/||/&&/ would not fix the problem as the root cause was identified > incorrectly. > > This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b. > Sorry for that, I will test your patches and respond to that. For this patch: Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
[toc] | [next] | [standalone]
| From | "Jayachandran C." <c.jayachandran@gmail.com> |
|---|---|
| Date | 2017-03-16 08:20 +0100 |
| Message-ID | <tlxRw-3e8-5@gated-at.bofh.it> |
| In reply to | #1600659 |
Hi Greg, On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 01/03/17 15:23, Aleksey Makarov wrote: >> The original patch makes the condition always true, so it is wrong. >> >> It masks (but not fixes) the bug described in the commit message >> but introduces a regression (no console is selected by SPCR) >> in regular (no 'console=ttyAMA') case. >> >> s/||/&&/ would not fix the problem as the root cause was identified >> incorrectly. >> >> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b. >> > > Sorry for that, I will test your patches and respond to that. For this > patch: > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > This fixes a regression I see in v4.11-rc2 Tested-by: Jayachandran C <jnair@caviumnetworks.com> I don't see it in the tty/serial tree yet JC.
[toc] | [prev] | [next] | [standalone]
| From | Aleksey Makarov <amakarov.linux@gmail.com> |
|---|---|
| Date | 2017-03-16 10:40 +0100 |
| Message-ID | <tlA2Z-4H0-7@gated-at.bofh.it> |
| In reply to | #1602013 |
On 03/16/2017 10:11 AM, Jayachandran C. wrote: > Hi Greg, > > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: >> >> >> On 01/03/17 15:23, Aleksey Makarov wrote: >>> The original patch makes the condition always true, so it is wrong. >>> >>> It masks (but not fixes) the bug described in the commit message >>> but introduces a regression (no console is selected by SPCR) >>> in regular (no 'console=ttyAMA') case. >>> >>> s/||/&&/ would not fix the problem as the root cause was identified >>> incorrectly. >>> >>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b. >>> >> >> Sorry for that, I will test your patches and respond to that. For this >> patch: >> >> Acked-by: Sudeep Holla <sudeep.holla@arm.com> >> > > This fixes a regression I see in v4.11-rc2 > > Tested-by: Jayachandran C <jnair@caviumnetworks.com> > > I don't see it in the tty/serial tree yet It's commit 713b93f1b849 from tty-next branch of https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git So it looks like it is scheduled for 4.12 Greg, this is a fix for regression. Can it be applied to 4.11-rcX? Thank you Aleksey Makarov > > JC. > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-17 06:10 +0100 |
| Message-ID | <tlSjg-10u-7@gated-at.bofh.it> |
| In reply to | #1602134 |
On Thu, Mar 16, 2017 at 12:31:53PM +0300, Aleksey Makarov wrote: > > > On 03/16/2017 10:11 AM, Jayachandran C. wrote: > > Hi Greg, > > > > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > >> > >> > >> On 01/03/17 15:23, Aleksey Makarov wrote: > >>> The original patch makes the condition always true, so it is wrong. > >>> > >>> It masks (but not fixes) the bug described in the commit message > >>> but introduces a regression (no console is selected by SPCR) > >>> in regular (no 'console=ttyAMA') case. > >>> > >>> s/||/&&/ would not fix the problem as the root cause was identified > >>> incorrectly. > >>> > >>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b. > >>> > >> > >> Sorry for that, I will test your patches and respond to that. For this > >> patch: > >> > >> Acked-by: Sudeep Holla <sudeep.holla@arm.com> > >> > > > > This fixes a regression I see in v4.11-rc2 > > > > Tested-by: Jayachandran C <jnair@caviumnetworks.com> > > > > I don't see it in the tty/serial tree yet > > It's commit 713b93f1b849 from tty-next branch of > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > > So it looks like it is scheduled for 4.12 > > Greg, this is a fix for regression. Can it be applied to 4.11-rcX? Yes, will do that now, thanks. greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web