Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets
Date	2017-03-09 18:50 +0100
Message-ID	<tjaml-8rP-9@gated-at.bofh.it> (permalink)
References	<tj0Gm-1Lv-13@gated-at.bofh.it> <ti2qS-1v4-21@gated-at.bofh.it> <tj19o-25r-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: David Howells <dhowells@redhat.com>
Date: Thu, 09 Mar 2017 07:51:34 +0000

> David Miller <davem@davemloft.net> wrote:
> 
>> I guess this is fine, but I think you can use one of the two "sk_padding"
>> bits in struct sock instead of making the structure larger.
> 
> It shouldn't make the structure larger since there's a hole in the structure:
 ...
> 		u16			sk_gso_max_segs;
>   ---> 2-byte hole here
> 		unsigned long	        sk_lingertime;
> 
> but I'll quite happily shift it to sk_padding.

Ok, then that's fine.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH net] net: Work around lockdep limitation in sockets that  use sockets David Howells <dhowells@redhat.com> - 2017-03-06 16:10 +0100
  Re: [RFC PATCH net] net: Work around lockdep limitation in sockets  that use sockets David Miller <davem@davemloft.net> - 2017-03-09 08:30 +0100
    Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets David Howells <dhowells@redhat.com> - 2017-03-09 09:00 +0100
      Re: [RFC PATCH net] net: Work around lockdep limitation in sockets  that use sockets David Miller <davem@davemloft.net> - 2017-03-09 18:50 +0100

csiph-web