Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets
Date	Thu, 09 Mar 2017 18:50:01 +0100
Message-ID	<tjaml-8rP-9@gated-at.bofh.it> (permalink)
References	<tj0Gm-1Lv-13@gated-at.bofh.it> <ti2qS-1v4-21@gated-at.bofh.it> <tj19o-25r-23@gated-at.bofh.it>
X-Original-To	dhowells@redhat.com
X-Mailer	Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Mar 2017 09:38:55 -0800 (PST)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 09 Mar 2017 09:38:51 -0800 (PST)
X-Original-Message-ID	<20170309.093851.1057108507009455288.davem@davemloft.net>
X-Original-References	<20170308.230625.719131946756053988.davem@davemloft.net> <148881267372.2618.822975702493802450.stgit@warthog.procyon.org.uk> <21773.1489045894@warthog.procyon.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1596247

Show key headers only | View raw

From: David Howells <dhowells@redhat.com>
Date: Thu, 09 Mar 2017 07:51:34 +0000

> David Miller <davem@davemloft.net> wrote:
> 
>> I guess this is fine, but I think you can use one of the two "sk_padding"
>> bits in struct sock instead of making the structure larger.
> 
> It shouldn't make the structure larger since there's a hole in the structure:
 ...
> 		u16			sk_gso_max_segs;
>   ---> 2-byte hole here
> 		unsigned long	        sk_lingertime;
> 
> but I'll quite happily shift it to sk_padding.

Ok, then that's fine.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH net] net: Work around lockdep limitation in sockets that  use sockets David Howells <dhowells@redhat.com> - 2017-03-06 16:10 +0100
  Re: [RFC PATCH net] net: Work around lockdep limitation in sockets  that use sockets David Miller <davem@davemloft.net> - 2017-03-09 08:30 +0100
    Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets David Howells <dhowells@redhat.com> - 2017-03-09 09:00 +0100
      Re: [RFC PATCH net] net: Work around lockdep limitation in sockets  that use sockets David Miller <davem@davemloft.net> - 2017-03-09 18:50 +0100

csiph-web