Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets
Date	2017-03-09 09:00 +0100
Message-ID	<tj19o-25r-23@gated-at.bofh.it> (permalink)
References	<tj0Gm-1Lv-13@gated-at.bofh.it> <ti2qS-1v4-21@gated-at.bofh.it> <tj0Gm-1Lv-13@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

David Miller <davem@davemloft.net> wrote:

> I guess this is fine, but I think you can use one of the two "sk_padding"
> bits in struct sock instead of making the structure larger.

It shouldn't make the structure larger since there's a hole in the structure:

		unsigned int		sk_padding : 2,
					sk_no_check_tx : 1,
					sk_no_check_rx : 1,
					sk_userlocks : 4,
					sk_protocol  : 8,
					sk_type      : 16;
	#define SK_PROTOCOL_MAX U8_MAX
		kmemcheck_bitfield_end(flags);

		u16			sk_gso_max_segs;
  ---> 2-byte hole here
		unsigned long	        sk_lingertime;

but I'll quite happily shift it to sk_padding.

Thanks,
David

Thread

[RFC PATCH net] net: Work around lockdep limitation in sockets that  use sockets David Howells <dhowells@redhat.com> - 2017-03-06 16:10 +0100
  Re: [RFC PATCH net] net: Work around lockdep limitation in sockets  that use sockets David Miller <davem@davemloft.net> - 2017-03-09 08:30 +0100
    Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets David Howells <dhowells@redhat.com> - 2017-03-09 09:00 +0100
      Re: [RFC PATCH net] net: Work around lockdep limitation in sockets  that use sockets David Miller <davem@davemloft.net> - 2017-03-09 18:50 +0100

csiph-web