Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593501

[PATCH v3 3/9] kasan: change allocation and freeing stack traces headers

Show all headers | View raw

Change stack traces headers from:

Allocated:
PID = 42

to:

Allocated by task 42:

Makes the report one line shorter and look better.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
 mm/kasan/report.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index fc0577d15671..382d4d2b9052 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -175,9 +175,9 @@ static void kasan_end_report(unsigned long *flags)
 	kasan_enable_current();
 }
 
-static void print_track(struct kasan_track *track)
+static void print_track(struct kasan_track *track, const char *prefix)
 {
-	pr_err("PID = %u\n", track->pid);
+	pr_err("%s by task %u:\n", prefix, track->pid);
 	if (track->stack) {
 		struct stack_trace trace;
 
@@ -199,10 +199,8 @@ static void kasan_object_err(struct kmem_cache *cache, void *object)
 	if (!(cache->flags & SLAB_KASAN))
 		return;
 
-	pr_err("Allocated:\n");
-	print_track(&alloc_info->alloc_track);
-	pr_err("Freed:\n");
-	print_track(&alloc_info->free_track);
+	print_track(&alloc_info->alloc_track, "Allocated");
+	print_track(&alloc_info->free_track, "Freed");
 }
 
 void kasan_report_double_free(struct kmem_cache *cache, void *object,
-- 
2.12.0.rc1.440.g5b76565f74-goog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] kasan: improve error reports Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 2/9] kasan: unify report headers Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 8/9] kasan: improve double-free report format Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 7/9] kasan: print page description after stacks Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 9/9] kasan: separate report parts by empty lines Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 1/9] kasan: introduce helper functions for determining bug type Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 6/9] kasan: improve slab object description Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 3/9] kasan: change allocation and freeing stack traces headers Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 4/9] kasan: simplify address description logic Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100

csiph-web