Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593498

[PATCH v3 9/9] kasan: separate report parts by empty lines

Show all headers | View raw

Makes the report easier to read.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
 mm/kasan/report.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index e5b762f4a6a4..2f3ff28b4d76 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -231,7 +231,9 @@ static void describe_object(struct kmem_cache *cache, void *object,
 
 	if (cache->flags & SLAB_KASAN) {
 		print_track(&alloc_info->alloc_track, "Allocated");
+		pr_err("\n");
 		print_track(&alloc_info->free_track, "Freed");
+		pr_err("\n");
 	}
 
 	describe_object_addr(cache, object, addr);
@@ -242,6 +244,7 @@ static void print_address_description(void *addr)
 	struct page *page = addr_to_page(addr);
 
 	dump_stack();
+	pr_err("\n");
 
 	if (page && PageSlab(page)) {
 		struct kmem_cache *cache = page->slab_cache;
@@ -320,7 +323,9 @@ void kasan_report_double_free(struct kmem_cache *cache, void *object,
 
 	kasan_start_report(&flags);
 	pr_err("BUG: KASAN: double-free or invalid-free in %pS\n", ip);
+	pr_err("\n");
 	print_address_description(object);
+	pr_err("\n");
 	print_shadow_for_address(object);
 	kasan_end_report(&flags);
 }
@@ -332,11 +337,13 @@ static void kasan_report_error(struct kasan_access_info *info)
 	kasan_start_report(&flags);
 
 	print_error_description(info);
+	pr_err("\n");
 
 	if (!addr_has_shadow(info)) {
 		dump_stack();
 	} else {
 		print_address_description((void *)info->access_addr);
+		pr_err("\n");
 		print_shadow_for_address(info->first_bad_addr);
 	}
 
-- 
2.12.0.rc1.440.g5b76565f74-goog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] kasan: improve error reports Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 2/9] kasan: unify report headers Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 8/9] kasan: improve double-free report format Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 7/9] kasan: print page description after stacks Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 9/9] kasan: separate report parts by empty lines Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 1/9] kasan: introduce helper functions for determining bug type Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 6/9] kasan: improve slab object description Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 3/9] kasan: change allocation and freeing stack traces headers Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 4/9] kasan: simplify address description logic Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100

csiph-web