Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1593497

[PATCH v3 7/9] kasan: print page description after stacks

Show all headers | View raw

Moves page description after the stacks since it's less important.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
 mm/kasan/report.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 87f8293d7b79..09a5f5b4bc79 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -255,9 +255,6 @@ static void print_address_description(struct kasan_access_info *info)
 	void *addr = (void *)info->access_addr;
 	struct page *page = addr_to_page(addr);
 
-	if (page)
-		dump_page(page, "kasan: bad access detected");
-
 	dump_stack();
 
 	if (page && PageSlab(page)) {
@@ -267,9 +264,14 @@ static void print_address_description(struct kasan_access_info *info)
 		describe_object(cache, object, addr);
 	}
 
-	if (kernel_or_module_addr(addr)) {
-		if (!init_task_stack_addr(addr))
-			pr_err("Address belongs to variable %pS\n", addr);
+	if (kernel_or_module_addr(addr) && !init_task_stack_addr(addr)) {
+		pr_err("The buggy address belongs to the variable:\n");
+		pr_err(" %pS\n", addr);
+	}
+
+	if (page) {
+		pr_err("The buggy address belongs to the page:\n");
+		dump_page(page, "kasan: bad access detected");
 	}
 }
 
-- 
2.12.0.rc1.440.g5b76565f74-goog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] kasan: improve error reports Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 2/9] kasan: unify report headers Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 8/9] kasan: improve double-free report format Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 7/9] kasan: print page description after stacks Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 9/9] kasan: separate report parts by empty lines Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 1/9] kasan: introduce helper functions for determining bug type Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 6/9] kasan: improve slab object description Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 3/9] kasan: change allocation and freeing stack traces headers Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100
  [PATCH v3 4/9] kasan: simplify address description logic Andrey Konovalov <andreyknvl@google.com> - 2017-03-06 17:10 +0100

csiph-web