Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1592678
| From | James Simmons <jsimmons@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer |
| Date | 2017-03-05 02:30 +0100 |
| Message-ID | <tht9L-Wr-11@gated-at.bofh.it> (permalink) |
| References | <thk6t-2Mc-3@gated-at.bofh.it> <thk6t-2Mc-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
> - (T*)
> e
> )
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 271e189..09b46924 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -640,7 +640,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
> int remote_gf_size = 0;
> int rc;
>
> - gf = (struct getinfo_fid2path *)karg;
> + gf = karg;
> tgt = lmv_find_target(lmv, &gf->gf_fid);
> if (IS_ERR(tgt))
> return PTR_ERR(tgt);
> @@ -657,7 +657,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
> struct getinfo_fid2path *ori_gf;
> char *ptr;
>
> - ori_gf = (struct getinfo_fid2path *)karg;
> + ori_gf = karg;
> if (strlen(ori_gf->gf_path) +
> strlen(gf->gf_path) > ori_gf->gf_pathlen) {
> rc = -EOVERFLOW;
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/5] Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 16:50 +0100
[PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 16:50 +0100
Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer James Simmons <jsimmons@infradead.org> - 2017-03-05 02:30 +0100
Re: [Outreachy kernel] [PATCH v5 0/5] Remove unnecessary cast on void pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-03-04 16:50 +0100
[PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:00 +0100
Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer James Simmons <jsimmons@infradead.org> - 2017-03-05 02:00 +0100
Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer Joe Perches <joe@perches.com> - 2017-03-04 17:00 +0100
Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
[PATCH v5 5/5] staging: rtl8712: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
[PATCH v5 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
[PATCH v5 4/5] staging: rts5208: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 18:10 +0100
csiph-web