Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1592533

Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer

Show all headers | View raw

On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote:
> This patch-series removes unnecessary cast on void pointer in various
> drivers.

Much better, thanks.

Trivia: (and it's probably not necessary to resend)

The cover letter should describe the subsystem being
changed or ideally something like "treewide" if the
series touches files throughout the kernel sources.

So this cover letter ideally would have a subject like:

Subject: [PATCH v5 0/5] staging: Remove unnecessary casts of void pointer

> v5:
>   -Fixed compliation warning in lustre/lustre/llite/range_lock.c
>    which remain unfixed in v3.
> v4:
>   -change the cover-letter subject
> v3:
>   -Fixed compilation warning in lustre/lustre/llite/range_lock.c	
> 
> simran singhal (5):
>   staging: nvec: Remove unnecessary cast on void pointer
>   staging: lustre: Remove unnecessary cast on void pointer
>   staging: lustre: lustre: Remove unnecessary cast on void pointer
>   staging: rts5208: Remove unnecessary cast on void pointer
>   staging: rtl8712: Remove unnecessary cast on void pointer

Some of these are acting on multiple instances.

Please try to use plural and singular descriptions
where appropriate.

>  drivers/staging/lustre/lustre/llite/range_lock.c |  2 +-
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c      |  4 ++--
>  drivers/staging/nvec/nvec_kbd.c                  |  2 +-
>  drivers/staging/rtl8712/rtl8712_recv.c           | 11 +++++------
>  drivers/staging/rts5208/rtsx_transport.c         |  3 +--
>  5 files changed, 10 insertions(+), 12 deletions(-)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/5] Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 16:50 +0100
  [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 16:50 +0100
    Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void  pointer James Simmons <jsimmons@infradead.org> - 2017-03-05 02:30 +0100
  Re: [Outreachy kernel] [PATCH v5 0/5] Remove unnecessary cast on  void pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-03-04 16:50 +0100
  [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:00 +0100
    Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast  on void pointer James Simmons <jsimmons@infradead.org> - 2017-03-05 02:00 +0100
  Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer Joe Perches <joe@perches.com> - 2017-03-04 17:00 +0100
    Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
  [PATCH v5 5/5] staging: rtl8712: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
  [PATCH v5 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
  [PATCH v5 4/5] staging: rts5208: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 18:10 +0100

csiph-web