Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1592665

Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

From James Simmons <jsimmons@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer
Date 2017-03-05 02:00 +0100
Message-ID <thsGJ-vv-3@gated-at.bofh.it> (permalink)
References <thk6t-2Mc-3@gated-at.bofh.it> <thkgb-2TF-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>

Reviewed-by: James Simmons <jsimmons@infradead.org>

> ---
> 
>  v5:
>    -Fixed compilation warnings.
> 
>  drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/range_lock.c b/drivers/staging/lustre/lustre/llite/range_lock.c
> index 14148a0..161391b 100644
> --- a/drivers/staging/lustre/lustre/llite/range_lock.c
> +++ b/drivers/staging/lustre/lustre/llite/range_lock.c
> @@ -174,7 +174,7 @@ void range_unlock(struct range_lock_tree *tree, struct range_lock *lock)
>   */
>  static enum interval_iter range_lock_cb(struct interval_node *node, void *arg)
>  {
> -	struct range_lock *lock = (struct range_lock *)arg;
> +	struct range_lock *lock = arg;
>  	struct range_lock *overlap = node2rangelock(node);
>  
>  	lock->rl_blocking_ranges += overlap->rl_lock_count + 1;
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5 0/5] Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 16:50 +0100
  [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 16:50 +0100
    Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void  pointer James Simmons <jsimmons@infradead.org> - 2017-03-05 02:30 +0100
  Re: [Outreachy kernel] [PATCH v5 0/5] Remove unnecessary cast on  void pointer Julia Lawall <julia.lawall@lip6.fr> - 2017-03-04 16:50 +0100
  [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:00 +0100
    Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast  on void pointer James Simmons <jsimmons@infradead.org> - 2017-03-05 02:00 +0100
  Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer Joe Perches <joe@perches.com> - 2017-03-04 17:00 +0100
    Re: [PATCH v5 0/5] Remove unnecessary cast on void pointer SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
  [PATCH v5 5/5] staging: rtl8712: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
  [PATCH v5 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 17:10 +0100
  [PATCH v5 4/5] staging: rts5208: Remove unnecessary cast on void pointer simran singhal <singhalsimran0@gmail.com> - 2017-03-04 18:10 +0100

csiph-web