Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583367

Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high

Show all headers | View raw

On 17/02/2017 17:23, Andy Shevchenko wrote:
> On Fri, Feb 17, 2017 at 11:12 AM, Phil Reid <preid@electromag.com.au> wrote:
>> When a threaded irq handler is chained attached to one of the gpio
>> pins when configure for level irq the altera_gpio_irq_leveL_high_handler
>> does not mask the interrupt while being handled by the chained irq.
>> This resulting in the threaded irq not getting enough cycles to complete
>> quickly enough before the irq was disabled as faulty.
>> It looks like handle_level_irq should be used in this situation
>> instead of handle_simple_irq.
>
>> @@ -310,7 +310,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
>>         altera_gc->interrupt_trigger = reg;
>>
>>         ret = gpiochip_irqchip_add(&altera_gc->mmchip.gc, &altera_irq_chip, 0,
>> -               handle_simple_irq, IRQ_TYPE_NONE);
>> +               altera_gc->interrupt_trigger == IRQ_TYPE_LEVEL_HIGH ?
>> +               handle_level_irq : handle_simple_irq, IRQ_TYPE_NONE);
>
> AFAIK, handle_bad_irq() should be used here.
>
G'day Andy

Grepping drivers/gpio find a combination of
handle_simple_irq
handle_level_irq
handle_edge_irq
handle_bad_irq
used in gpiochip_irqchip_add

The ones which use handle_bad_irq call irq_set_handler_locked in their
irq_type callback to either handle_level_irq / handle_edge_irq

So I think in this case it's correct. But I'm no expert.

-- 
Regards
Phil Reid

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high Phil Reid <preid@electromag.com.au> - 2017-02-17 10:20 +0100
  Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as  a level_high Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-17 10:30 +0100
    Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as  a level_high Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-17 12:50 +0100
    Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as  a level_high Phil Reid <preid@electromag.com.au> - 2017-02-17 12:50 +0100
  Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as  a level_high Linus Walleij <linus.walleij@linaro.org> - 2017-02-23 16:00 +0100

csiph-web