Re: [PATCH v3] softirq: Prevent looping on disabled tasklets

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] softirq: Prevent looping on disabled tasklets
Date	2017-02-17 13:00 +0100
Message-ID	<tbPmF-3Oz-1@gated-at.bofh.it> (permalink)
References	<ta30K-7i0-9@gated-at.bofh.it> <ta4zw-84o-5@gated-at.bofh.it> <ta4SS-8qq-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 12 Feb 2017, Chris Wilson wrote:

> On Sun, Feb 12, 2017 at 03:46:09PM +0000, Chris Wilson wrote:
> > +void tasklet_enable(struct tasklet_struct *t)
> > +{
> > +	if (!atomic_dec_and_test(&t->count))
> > +		return;
> > +
> > +	if (test_bit(TASKLET_STATE_SCHED, &t->state))
> > +		raise_softirq(HI_SOFTIRQ | TASKLET_SOFTIRQ);
> 
> And of course this can't work as raise_softirq() is local to the cpu.

Indeed. tasklets are a horror by design. We rather should make them go away.

Thanks,

	tglx

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3] softirq: Prevent looping on disabled tasklets Thomas Gleixner <tglx@linutronix.de> - 2017-02-17 13:00 +0100

csiph-web