Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements

From	Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements
Date	2017-07-05 22:50 +0200
Message-ID	<tZZpg-2RM-17@gated-at.bofh.it> (permalink)
References	<tZPzz-4Wj-1@gated-at.bofh.it> <tZQYG-5GJ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/07/17 23:49, Andy Shevchenko wrote:
> On Wed, Jul 5, 2017 at 1:13 PM, Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
>> This series addresses some of the points identified by Andy. The series is
>> based on top of i2c/for-next. 2 of the patches from v1 have already been
>> applied so I've dropped them from this version.
>>
>> I have compile tested patch 1/1 but I don't have access to sh hardware
>> to actually test the changes on.
> 
> 
> Entire series looks good to me:
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Further improvement is to get timeout value via device properties API
> and get rid of legacy platform data completely. This can be done in
> further series.

Actually the timeout can probably go now. The two in-tree platforms that 
set it via platform_data set it to HZ which is (now) the default.

> 
>>
>> Chris Packham (4):
>>    sh: sh7785lcr: add GPIO lookup table for i2c controller reset
>>    i2c: pca-platform: unconditionally use devm_gpiod_get_optional
>>    i2c: pca-platform: use device_property_read_u32
>>    i2c: pca-platform: drop gpio from platform data
>>
>>   arch/blackfin/mach-bf561/boards/acvilon.c |  1 -
>>   arch/sh/boards/board-sh7785lcr.c          | 11 +++++++++-
>>   drivers/i2c/busses/i2c-pca-platform.c     | 34 +++++++++----------------------
>>   include/linux/i2c-pca-platform.h          |  3 ---
>>   4 files changed, 20 insertions(+), 29 deletions(-)
>>
>> --
>> 2.13.0
>>
> 
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 3/4] i2c: pca-platform: use device_property_read_u32 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 1/4] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 4/4] i2c: pca-platform: drop gpio from platform data Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 2/4] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-05 13:50 +0200
    Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-07-05 22:50 +0200

csiph-web