Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681431

[PATCH v2 2/4] i2c: pca-platform: unconditionally use devm_gpiod_get_optional

Show all headers | View raw

Allow for the reset-gpios property to be defined in the device tree
or via a GPIO lookup table.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Changes in v2:
- move call up above platform_data usage

 drivers/i2c/busses/i2c-pca-platform.c | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index 853a2abedb05..b90193d09d4b 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -173,33 +173,20 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	i2c->adap.dev.parent = &pdev->dev;
 	i2c->adap.dev.of_node = np;
 
+	i2c->gpio = devm_gpiod_get_optional(&pdev->dev, "reset-gpios", GPIOD_OUT_LOW);
+	if (IS_ERR(i2c->gpio))
+		return PTR_ERR(i2c->gpio);
+
 	if (platform_data) {
 		i2c->adap.timeout = platform_data->timeout;
 		i2c->algo_data.i2c_clock = platform_data->i2c_clock_speed;
-		if (gpio_is_valid(platform_data->gpio)) {
-			ret = devm_gpio_request_one(&pdev->dev,
-						    platform_data->gpio,
-						    GPIOF_ACTIVE_LOW,
-						    i2c->adap.name);
-			if (ret == 0) {
-				i2c->gpio = gpio_to_desc(platform_data->gpio);
-				gpiod_direction_output(i2c->gpio, 0);
-			} else {
-				dev_warn(&pdev->dev, "Registering gpio failed!\n");
-				i2c->gpio = NULL;
-			}
-		}
 	} else if (np) {
 		i2c->adap.timeout = HZ;
-		i2c->gpio = devm_gpiod_get_optional(&pdev->dev, "reset-gpios", GPIOD_OUT_LOW);
-		if (IS_ERR(i2c->gpio))
-			return PTR_ERR(i2c->gpio);
 		of_property_read_u32_index(np, "clock-frequency", 0,
 					   &i2c->algo_data.i2c_clock);
 	} else {
 		i2c->adap.timeout = HZ;
 		i2c->algo_data.i2c_clock = 59000;
-		i2c->gpio = NULL;
 	}
 
 	i2c->algo_data.data = i2c;
-- 
2.13.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 3/4] i2c: pca-platform: use device_property_read_u32 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 1/4] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 4/4] i2c: pca-platform: drop gpio from platform data Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 2/4] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-05 13:50 +0200
    Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-07-05 22:50 +0200

csiph-web