Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681427

[PATCH v2 3/4] i2c: pca-platform: use device_property_read_u32

Show all headers | View raw

Use device_property_read_u32 instead of of_property_read_u32_index to
lookup the "clock-frequency" property.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Changes in v2:
- move call to device_property_read_u32 to above platform_data usage.
  This allows the device property/device tree to go first and
  platform_data (if present) can override things. Eventually when all
  the platforms using this driver are converted to either use device
  properties or a device tree then the platform_data can simply be
  deleted.

 drivers/i2c/busses/i2c-pca-platform.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index b90193d09d4b..bc2707ffd409 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -177,16 +177,15 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	if (IS_ERR(i2c->gpio))
 		return PTR_ERR(i2c->gpio);
 
+	i2c->adap.timeout = HZ;
+	ret = device_property_read_u32(&pdev->dev, "clock-frequency",
+				       &i2c->algo_data.i2c_clock);
+	if (ret)
+		i2c->algo_data.i2c_clock = 59000;
+
 	if (platform_data) {
 		i2c->adap.timeout = platform_data->timeout;
 		i2c->algo_data.i2c_clock = platform_data->i2c_clock_speed;
-	} else if (np) {
-		i2c->adap.timeout = HZ;
-		of_property_read_u32_index(np, "clock-frequency", 0,
-					   &i2c->algo_data.i2c_clock);
-	} else {
-		i2c->adap.timeout = HZ;
-		i2c->algo_data.i2c_clock = 59000;
 	}
 
 	i2c->algo_data.data = i2c;
-- 
2.13.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 3/4] i2c: pca-platform: use device_property_read_u32 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 1/4] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 4/4] i2c: pca-platform: drop gpio from platform data Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  [PATCH v2 2/4] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-07-05 12:20 +0200
  Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-05 13:50 +0200
    Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-07-05 22:50 +0200

csiph-web