Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672721
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: linux-next: build failure after merge of most trees |
| Date | 2017-06-22 17:00 +0200 |
| Message-ID | <tVbKq-67R-39@gated-at.bofh.it> (permalink) |
| References | <tV5Ym-2e1-29@gated-at.bofh.it> <tVb7H-5Qr-7@gated-at.bofh.it> <tVbr4-5Yi-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Nicholas Piggin <npiggin@gmail.com> Date: Fri, 23 Jun 2017 00:33:39 +1000 > On Thu, 22 Jun 2017 10:13:06 -0400 (EDT) > David Miller <davem@davemloft.net> wrote: > >> From: Nicholas Piggin <npiggin@gmail.com> >> Date: Thu, 22 Jun 2017 18:41:16 +1000 >> >> > Is there any way for the linker to place the inputs to avoid unresolvable >> > relocations where possible? >> >> I don't think so. >> >> > A way to work around this is to make arch/sparc/lib/hweight.o an obj-y >> > rather than lib-y. That's a hack because it just serves to move the >> > input location, but not really any more of a hack than the current code >> > that also only works because of input locations... >> >> I could adjust those branches in the sparc code into indirect calls >> but it's going to perform a bit poorly on older cpus. > > The build succeeds with your patch. That should solve it properly > so it won't come back to bite again. > > If you can tolerate the slowdown on old CPUs I'd be grateful if > we could merge it for linux-next to get this thin archives tree > unblocked. Feel free to merge it into your series: ==================== sparc64: Use indirect calls in hamming weight stubs. Otherwise, depending upon link order, the branch relocation limits could be exceeded. Signed-off-by: David S. Miller <davem@davemloft.net> diff --git a/arch/sparc/lib/hweight.S b/arch/sparc/lib/hweight.S index f9985f1..d21cf20 100644 --- a/arch/sparc/lib/hweight.S +++ b/arch/sparc/lib/hweight.S @@ -4,9 +4,9 @@ .text .align 32 ENTRY(__arch_hweight8) - ba,pt %xcc, __sw_hweight8 + sethi %hi(__sw_hweight8), %g1 + jmpl %g1 + %lo(__sw_hweight8), %g0 nop - nop ENDPROC(__arch_hweight8) EXPORT_SYMBOL(__arch_hweight8) .section .popc_3insn_patch, "ax" @@ -17,9 +17,9 @@ EXPORT_SYMBOL(__arch_hweight8) .previous ENTRY(__arch_hweight16) - ba,pt %xcc, __sw_hweight16 + sethi %hi(__sw_hweight16), %g1 + jmpl %g1 + %lo(__sw_hweight16), %g0 nop - nop ENDPROC(__arch_hweight16) EXPORT_SYMBOL(__arch_hweight16) .section .popc_3insn_patch, "ax" @@ -30,9 +30,9 @@ EXPORT_SYMBOL(__arch_hweight16) .previous ENTRY(__arch_hweight32) - ba,pt %xcc, __sw_hweight32 + sethi %hi(__sw_hweight32), %g1 + jmpl %g1 + %lo(__sw_hweight32), %g0 nop - nop ENDPROC(__arch_hweight32) EXPORT_SYMBOL(__arch_hweight32) .section .popc_3insn_patch, "ax" @@ -43,9 +43,9 @@ EXPORT_SYMBOL(__arch_hweight32) .previous ENTRY(__arch_hweight64) - ba,pt %xcc, __sw_hweight64 + sethi %hi(__sw_hweight16), %g1 + jmpl %g1 + %lo(__sw_hweight16), %g0 nop - nop ENDPROC(__arch_hweight64) EXPORT_SYMBOL(__arch_hweight64) .section .popc_3insn_patch, "ax"
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
linux-next: build failure after merge of most trees Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-22 07:30 +0200
Re: linux-next: build failure after merge of most trees Nicholas Piggin <npiggin@gmail.com> - 2017-06-22 08:00 +0200
Re: linux-next: build failure after merge of most trees Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-22 08:30 +0200
Re: linux-next: build failure after merge of most trees Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-22 08:30 +0200
Re: linux-next: build failure after merge of most trees Nicholas Piggin <npiggin@gmail.com> - 2017-06-22 10:50 +0200
Re: linux-next: build failure after merge of most trees David Miller <davem@davemloft.net> - 2017-06-22 16:20 +0200
Re: linux-next: build failure after merge of most trees David Miller <davem@davemloft.net> - 2017-06-22 16:30 +0200
Re: linux-next: build failure after merge of most trees Nicholas Piggin <npiggin@gmail.com> - 2017-06-23 05:50 +0200
Re: linux-next: build failure after merge of most trees Nicholas Piggin <npiggin@gmail.com> - 2017-06-22 16:40 +0200
Re: linux-next: build failure after merge of most trees David Miller <davem@davemloft.net> - 2017-06-22 17:00 +0200
Re: linux-next: build failure after merge of most trees Nicholas Piggin <npiggin@gmail.com> - 2017-06-23 05:40 +0200
RE: linux-next: build failure after merge of most trees <yamada.masahiro@socionext.com> - 2017-06-23 08:50 +0200
Re: linux-next: build failure after merge of most trees Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-23 09:10 +0200
Re: linux-next: build failure after merge of most trees David Miller <davem@davemloft.net> - 2017-06-23 17:20 +0200
Re: linux-next: build failure after merge of most trees Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-23 08:50 +0200
Re: linux-next: build failure after merge of most trees Alan Modra <amodra@gmail.com> - 2017-06-22 16:20 +0200
Re: linux-next: build failure after merge of most trees Nicholas Piggin <npiggin@gmail.com> - 2017-06-22 16:50 +0200
csiph-web