Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664223

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

Show all headers | View raw

On Mon, Jun 12, 2017 at 10:30 PM, Babu Moger <babu.moger@oracle.com> wrote:
>
> Looks like microblaze can be configured to either little or big endian
> formats.  How about
> adding a choice statement to address this.
> Here is my proposed patch.

Hi Babu,

This part looks fine, but I think we also need this one:

diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
index 740f2b82a182..1f6c486826a0 100644
--- a/arch/microblaze/Makefile
+++ b/arch/microblaze/Makefile
@@ -35,6 +35,8 @@ endif
 CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_DIV) += -mno-xl-soft-div
 CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_BARREL) += -mxl-barrel-shift
 CPUFLAGS-$(CONFIG_XILINX_MICROBLAZE0_USE_PCMP_INSTR) += -mxl-pattern-compare
+CPUFLAGS-$(CONFIG_BIG_ENDIAN) += -mbig-endian
+CPUFLAGS-$(CONFIG_LITTLE_ENDIAN) += -mlittle-endian

 CPUFLAGS-1 += $(call cc-option,-mcpu=v$(CPU_VER))


That way, we don't have to guess what the toolchain does, but rather
tell it to do whatever is configured, like we do for most other architectures.

Unfortunately we can't do the same thing on xtensa, as that no longer
supports the -mbig-endian/-mbig-endian flags in any recent gcc version
(a long time ago it had them, but they were removed along with many other
options).

        Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-09 00:20 +0200
  Re: [PATCH 2/2] include: warn for inconsistent endian config definition Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 09:10 +0200
    Re: [PATCH 2/2] include: warn for inconsistent endian config definition Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 09:20 +0200
      Re: [PATCH 2/2] include: warn for inconsistent endian config  definition Babu Moger <babu.moger@oracle.com> - 2017-06-09 16:00 +0200
        Re: [PATCH 2/2] include: warn for inconsistent endian config definition Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 16:20 +0200
          Re: [PATCH 2/2] include: warn for inconsistent endian config  definition Babu Moger <babu.moger@oracle.com> - 2017-06-09 16:50 +0200
  Re: [PATCH 2/2] include: warn for inconsistent endian config  definition kbuild test robot <lkp@intel.com> - 2017-06-10 16:10 +0200
    Re: [PATCH 2/2] include: warn for inconsistent endian config  definition Babu Moger <babu.moger@oracle.com> - 2017-06-12 22:40 +0200
      Re: [PATCH 2/2] include: warn for inconsistent endian config definition Max Filippov <jcmvbkbc@gmail.com> - 2017-06-12 23:00 +0200
        Re: [PATCH 2/2] include: warn for inconsistent endian config  definition Babu Moger <babu.moger@oracle.com> - 2017-06-12 23:40 +0200
      Re: [PATCH 2/2] include: warn for inconsistent endian config definition Arnd Bergmann <arnd@arndb.de> - 2017-06-12 23:00 +0200
        Re: [PATCH 2/2] include: warn for inconsistent endian config  definition Babu Moger <babu.moger@oracle.com> - 2017-06-12 23:30 +0200

csiph-web