Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1661995
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] include: warn for inconsistent endian config definition |
| Date | 2017-06-09 09:10 +0200 |
| Message-ID | <tQmds-6TG-17@gated-at.bofh.it> (permalink) |
| References | <tQdWy-1BJ-19@gated-at.bofh.it> <tQdWz-1BJ-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 9, 2017 at 12:17 AM, Babu Moger <babu.moger@oracle.com> wrote:
> Display warning if CPU_BIG_ENDIAN is not defined on big endian
> architecture and also warn if it defined on little endian architectures.
>
> We have seen some generic code(for example code include/asm-generic/qrwlock.h)
> uses CONFIG_CPU_BIG_ENDIAN to decide the endianess.
That example is IMHO the least harmful, as qrwlock must be selected explicitly
by the architecture.
The uses in
drivers/of/base.c
drivers/of/fdt.c
drivers/tty/serial/earlycon.c
drivers/tty/serial/serial_core.c
are more dangerous, and may have bitten people already.
In addition, people may have worked around them in DT, so this series may
actually introduce regressions.
> Here is the original discussion
> http://www.spinics.net/lists/devicetree/msg178101.html
>
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
Hmm, the link above refers to a mail from me? ;-)
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-09 00:20 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 09:10 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 09:20 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-09 16:00 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 16:20 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-09 16:50 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition kbuild test robot <lkp@intel.com> - 2017-06-10 16:10 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-12 22:40 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Max Filippov <jcmvbkbc@gmail.com> - 2017-06-12 23:00 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-12 23:40 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Arnd Bergmann <arnd@arndb.de> - 2017-06-12 23:00 +0200
Re: [PATCH 2/2] include: warn for inconsistent endian config definition Babu Moger <babu.moger@oracle.com> - 2017-06-12 23:30 +0200
csiph-web