Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document

From	Al Cooper <al.cooper@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document
Date	2017-06-12 23:00 +0200
Message-ID	<tREBk-77B-19@gated-at.bofh.it> (permalink)
References	<tNZbj-4Ci-1@gated-at.bofh.it> <tNZbj-4Ci-3@gated-at.bofh.it> <tQdWy-1BJ-11@gated-at.bofh.it> <tRDYC-6RQ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 12, 2017 at 4:19 PM, Al Cooper <al.cooper@broadcom.com> wrote:
> On Thu, Jun 8, 2017 at 6:11 PM, Rob Herring <robh@kernel.org> wrote:
>>> +- brcm,device: String, PHY Device mode.
>>> +  Possible values are: off (Host), on (Device), dual (DRD)
>>> +  or typec-pd (Type-C PD control)
>>
>> I believe we have standard property for this though maybe not type C.
>>
>> off/on seem strange for meaning host/device as well.
>
> I'll change this to:
>
> mode: String, PHY Device mode.
> Possible values are: "host", "device", "drd" or "typec-pd"

I just found "dr_mode" in Documentation/devicetree/bindings/usb/generic.txt.
I'd like to change this to:

dr_mode: String, PHY Device mode.
Possible values are: "host", "device", "drd" or "typec-pd"

I used a standard property name ("dr_mode") and 2 of the standard
values ("host", "device") and added 2 new values "drd" and "typec_pd".

Thanks
Al

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding  document Rob Herring <robh@kernel.org> - 2017-06-09 00:20 +0200
  Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper <al.cooper@broadcom.com> - 2017-06-12 22:20 +0200
    Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper <al.cooper@broadcom.com> - 2017-06-12 23:00 +0200

csiph-web