Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658418
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list |
| Date | 2017-06-06 09:20 +0200 |
| Message-ID | <tPgWt-5BA-9@gated-at.bofh.it> (permalink) |
| References | <tNRnr-7G9-3@gated-at.bofh.it> <tNRnr-7G9-5@gated-at.bofh.it> <tOSUa-79A-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/05/2017 07:31 AM, Christoph Hellwig wrote:
> What about a little helper like this: ?
>
> static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
> void *id, off_t *off)
> {
> struct nvme_ns_identifier_hdr hdr = {
> .nidt = type,
> .nidl = len,
> };
> u16 status;
>
> status = nvmet_copy_to_sgl(req, *off, &hdr, sizeof(hdr));
> if (status)
> return status;
> *off += sizeof(hdr);
>
> status = nvmet_copy_to_sgl(req, off, id, len);
> if (status)
> return status;
> *off += len;
>
> return 0;
> }
>
Yep sounds good. Sorry I didn't see this for the v4 submission, I'll
include in (the hopefully final) v5.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-02 11:50 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Sagi Grimberg <sagi@grimberg.me> - 2017-06-02 15:50 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-02 16:00 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Christoph Hellwig <hch@lst.de> - 2017-06-03 07:20 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Sagi Grimberg <sagi@grimberg.me> - 2017-06-03 10:10 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 09:20 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Christoph Hellwig <hch@lst.de> - 2017-06-06 09:20 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 09:30 +0200
csiph-web