Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1657276

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list
Date 2017-06-05 07:40 +0200
Message-ID <tOSUa-79A-5@gated-at.bofh.it> (permalink)
References <tNRnr-7G9-3@gated-at.bofh.it> <tNRnr-7G9-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


What about a little helper like this: ?

static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
		void *id, off_t *off)
{
	struct nvme_ns_identifier_hdr hdr = {
		.nidt	= type,
		.nidl	= len,
	};
	u16 status;

	status = nvmet_copy_to_sgl(req, *off, &hdr, sizeof(hdr));
	if (status)
		return status;
	*off += sizeof(hdr);

	status = nvmet_copy_to_sgl(req, off, id, len);
	if (status)
		return status;
	*off += len;

	return 0;
}

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-02 11:50 +0200
  Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor  list Sagi Grimberg <sagi@grimberg.me> - 2017-06-02 15:50 +0200
    Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor  list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-02 16:00 +0200
    Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor         list Christoph Hellwig <hch@lst.de> - 2017-06-03 07:20 +0200
      Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor  list Sagi Grimberg <sagi@grimberg.me> - 2017-06-03 10:10 +0200
  Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor         list Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
    Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor  list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 09:20 +0200
      Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor         list Christoph Hellwig <hch@lst.de> - 2017-06-06 09:20 +0200
        Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor  list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 09:30 +0200

csiph-web