Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1656716
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list |
| Date | 2017-06-03 07:20 +0200 |
| Message-ID | <tO9DH-2OS-5@gated-at.bofh.it> (permalink) |
| References | <tNRnr-7G9-3@gated-at.bofh.it> <tNRnr-7G9-5@gated-at.bofh.it> <tNV7H-1R8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 02, 2017 at 04:46:40PM +0300, Sagi Grimberg wrote:
>
>> switch (type) {
>> case NVME_NQN_NVME:
>> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
>> index cfc5c7fb0ab7..4c6cb5ea1186 100644
>> --- a/drivers/nvme/target/nvmet.h
>> +++ b/drivers/nvme/target/nvmet.h
>> @@ -46,6 +46,7 @@ struct nvmet_ns {
>> u32 blksize_shift;
>> loff_t size;
>> u8 nguid[16];
>> + uuid_be uuid;
>
> This should be uuid_le to match the rest of NVMe.
It shouldn't. A RFC4122 uuid is always in "big endian" notation.
A little endiane uuid doesn't exist, it's called a GUID in Wintel
speak and isn't used in NVMe. My new uuid tree tries to fix up
the confusion by renaming our uuid_be type to uuid_t and uuid_le
to guid_t.
> Also, it would be useful to generate a random default with uuid_le_gen()
> for a better out-of-the-box experience.
That's actually a good point. Just needs to be uuid_be_gen/uuid_gen :)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-02 11:50 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Sagi Grimberg <sagi@grimberg.me> - 2017-06-02 15:50 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-02 16:00 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Christoph Hellwig <hch@lst.de> - 2017-06-03 07:20 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Sagi Grimberg <sagi@grimberg.me> - 2017-06-03 10:10 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 09:20 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Christoph Hellwig <hch@lst.de> - 2017-06-06 09:20 +0200
Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-06 09:30 +0200
csiph-web