Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659518

Re: [PATCH] acpi: handle the acpi hotplug schedule error

Show all headers | View raw

On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
> Kernel should decrements the reference count of acpi device
> when scheduling acpi hotplug work is failed, and also evaluates
> _OST to notify BIOS the failure.

> -       if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> -               return;
> +       if (hotplug_event) {
> +               if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) {
> +                       acpi_bus_put_acpi_device(adev);
> +                       goto err;
> +               } else {
> +                       return;
> +               }
> +       }

Wouldn't be simpler to

-               return;
+               goto err_put_device;

+ err_put_device:
+       acpi_bus_put_acpi_device(adev);
 err:

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi: handle the acpi hotplug schedule error "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2017-06-07 08:10 +0200
  Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 10:40 +0200
    Re: [PATCH] acpi: handle the acpi hotplug schedule error joeyli <jlee@suse.com> - 2017-06-07 12:20 +0200
      Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 12:50 +0200
        Re: [PATCH] acpi: handle the acpi hotplug schedule error joeyli <jlee@suse.com> - 2017-06-07 17:50 +0200
          Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 19:00 +0200

csiph-web