[PATCH] acpi: handle the acpi hotplug schedule error

From	"Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] acpi: handle the acpi hotplug schedule error
Date	2017-06-07 08:10 +0200
Message-ID	<tPCki-2Lp-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Kernel should decrements the reference count of acpi device
when scheduling acpi hotplug work is failed, and also evaluates
_OST to notify BIOS the failure.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
 drivers/acpi/bus.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 34fbe02..2f2cec9 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -427,8 +427,14 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
 	    (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
 		driver->ops.notify(adev, type);
 
-	if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
-		return;
+	if (hotplug_event) {
+		if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) {
+			acpi_bus_put_acpi_device(adev);
+			goto err;
+		} else {
+			return;
+		}
+	}
 
 	acpi_bus_put_acpi_device(adev);
 	return;
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi: handle the acpi hotplug schedule error "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2017-06-07 08:10 +0200
  Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 10:40 +0200
    Re: [PATCH] acpi: handle the acpi hotplug schedule error joeyli <jlee@suse.com> - 2017-06-07 12:20 +0200
      Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 12:50 +0200
        Re: [PATCH] acpi: handle the acpi hotplug schedule error joeyli <jlee@suse.com> - 2017-06-07 17:50 +0200

csiph-web