Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1659666
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] acpi: handle the acpi hotplug schedule error |
| Date | 2017-06-07 12:50 +0200 |
| Message-ID | <tPGHf-5ui-5@gated-at.bofh.it> (permalink) |
| References | <tPCki-2Lp-9@gated-at.bofh.it> <tPEFs-4bF-13@gated-at.bofh.it> <tPGed-5it-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 7, 2017 at 1:18 PM, joeyli <jlee@suse.com> wrote:
> On Wed, Jun 07, 2017 at 11:36:55AM +0300, Andy Shevchenko wrote:
>> On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
>> > Kernel should decrements the reference count of acpi device
>> > when scheduling acpi hotplug work is failed, and also evaluates
>> > _OST to notify BIOS the failure.
> So, do you mean like this?
Yes, see below.
>
> - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> - return;
> + if (hotplug_event) {
> + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> + return;
> + else
It's redundant...
> + goto err_put_device;
...perhaps
if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type)))
goto err_put_device;
return;
> + }
>
> acpi_bus_put_acpi_device(adev);
> return;
>
> +err_put_device:
> + acpi_bus_put_acpi_device(adev);
> err:
> acpi_evaluate_ost(handle, type, ost_code, NULL);
> }
--
With Best Regards,
Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] acpi: handle the acpi hotplug schedule error "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2017-06-07 08:10 +0200
Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 10:40 +0200
Re: [PATCH] acpi: handle the acpi hotplug schedule error joeyli <jlee@suse.com> - 2017-06-07 12:20 +0200
Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 12:50 +0200
Re: [PATCH] acpi: handle the acpi hotplug schedule error joeyli <jlee@suse.com> - 2017-06-07 17:50 +0200
Re: [PATCH] acpi: handle the acpi hotplug schedule error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 19:00 +0200
csiph-web