Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228

From	"David.Wu" <david.wu@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228
Date	2017-05-26 05:40 +0200
Message-ID	<tLegx-AF-1@gated-at.bofh.it> (permalink)
References	<tL0Qh-fG-3@gated-at.bofh.it> <tL0Qi-fG-25@gated-at.bofh.it> <tL8kN-51l-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Heiko,

在 2017/5/26 5:12, Heiko Stuebner 写道:
> Requiring developers to calculate this pin-bit-value for each bank
> is cumbersome and error-prone. With the routes-struct known in
> the driver (see above and below), you can keep the the value element
> in rockchip_pin_bank, but calculate the per-bank value dynamically
> when the bank gets created.
> 
> For example in rockchip_pinctrl_get_soc_data just parse the route-struct
> and calculate that value when the driver probes.
> 
> This reduces possible errors and also spares us the clutter of all the
> additional PIN_BANK_* defines.

It is good to calculate the per-bank value dynamically, Thanks.☺

Thread

[PATCH 0/4] Add iomux-route switching support David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200
  [PATCH 3/4] pinctrl: rockchip: Add iomux-route switching support for rk3328 David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200
  [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228 David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200
    Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228 Heiko Stuebner <heiko@sntech.de> - 2017-05-25 23:20 +0200
      Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support  for rk3228 "David.Wu" <david.wu@rock-chips.com> - 2017-05-26 05:40 +0200
  [PATCH 1/4] pinctrl: rockchip: Add iomux-route switching support David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200

csiph-web