Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"David.Wu" <david.wu@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228
Date	Fri, 26 May 2017 05:40:01 +0200
Message-ID	<tLegx-AF-1@gated-at.bofh.it> (permalink)
References	<tL0Qh-fG-3@gated-at.bofh.it> <tL0Qi-fG-25@gated-at.bofh.it> <tL8kN-51l-9@gated-at.bofh.it>
X-Original-To	Heiko Stuebner <heiko@sntech.de>
X-263anti-Spam	KSV:0;
X-Mail-Gray	1
X-Abs-Checked	4
X-Rl-Sender	david.wu@rock-chips.com
X-Fst-To	linux-kernel@vger.kernel.org
X-Sender-IP	58.22.7.114
X-Login-Name	david.wu@rock-chips.com
X-Unique-Tag	<329fbda8547b84b8c10b91f30c227fee>
X-Sender	wdc@rock-chips.com
User-Agent	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	linus.walleij@linaro.org, huangtao@rock-chips.com, dianders@chromium.org, linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 26 May 2017 11:38:57 +0800
X-Original-Message-ID	<a36f756f-9454-adf7-18aa-3e46c3d79cde@rock-chips.com>
X-Original-References	<1495717952-9762-1-git-send-email-david.wu@rock-chips.com> <1495717952-9762-3-git-send-email-david.wu@rock-chips.com> <3063930.sJt1b8WyHP@phil>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1651056

Show key headers only | View raw

Hi Heiko,

在 2017/5/26 5:12, Heiko Stuebner 写道:
> Requiring developers to calculate this pin-bit-value for each bank
> is cumbersome and error-prone. With the routes-struct known in
> the driver (see above and below), you can keep the the value element
> in rockchip_pin_bank, but calculate the per-bank value dynamically
> when the bank gets created.
> 
> For example in rockchip_pinctrl_get_soc_data just parse the route-struct
> and calculate that value when the driver probes.
> 
> This reduces possible errors and also spares us the clutter of all the
> additional PIN_BANK_* defines.

It is good to calculate the per-bank value dynamically, Thanks.☺

Thread

[PATCH 0/4] Add iomux-route switching support David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200
  [PATCH 3/4] pinctrl: rockchip: Add iomux-route switching support for rk3328 David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200
  [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228 David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200
    Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support for rk3228 Heiko Stuebner <heiko@sntech.de> - 2017-05-25 23:20 +0200
      Re: [PATCH 2/4] pinctrl: rockchip: Add iomux-route switching support  for rk3228 "David.Wu" <david.wu@rock-chips.com> - 2017-05-26 05:40 +0200
  [PATCH 1/4] pinctrl: rockchip: Add iomux-route switching support David Wu <david.wu@rock-chips.com> - 2017-05-25 15:20 +0200

csiph-web