Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static
Date	2017-05-23 10:40 +0200
Message-ID	<tKdwe-Fm-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <tIOTf-1TM-5@gated-at.bofh.it> <tIW4p-6Vz-5@gated-at.bofh.it> <tIWnL-7i2-13@gated-at.bofh.it> <tIWxr-7lL-3@gated-at.bofh.it> <tKdcR-x7-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 23, 2017 at 11:19:58AM +0300, Jani Nikula wrote:
> On Fri, 19 May 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote:
> >> OK, that's definitely not how I've read the
> >> Documentation/process/submitting-patches.rst description of the Fixes
> >> tag, which talks about bugs found with git bisect and things that should
> >> go to -stable.  I would not have considered what this patch is changing
> >> to be a bug.
> >
> > True.  I don't consider this a bug either.  I wouldn't have included a
> > Fixes tag.
> >
> > I pretty much agree with the submitting-patches.rst except it should
> > probably say to include it on more stuff.  Fixes: tags are required for
> > all bugfixes to netdev for example.
> 
> We use Fixes: in drm/i915 to basically indicate that the referenced
> commit has a bug that actually needs to be fixed, this patch is the fix,
> and should go wherever the referenced commit goes. Annotating typo fixes
> and missing static keywords and such is just noise from *our* POV, and
> need to be filtered out.

Yes, yes.  I agree.  Fixes should fix a bug.  I'm sorry, I didn't read
the original patch carefully, I just saw that people said Fixes meant
backporting to -stable.

regards,
dan carpenter

Thread

[PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Colin King <colin.king@canonical.com> - 2017-05-19 13:10 +0200
  Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-19 14:10 +0200
    Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Eric Anholt <eric@anholt.net> - 2017-05-19 20:20 +0200
      Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:50 +0200
    Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:50 +0200
      Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Eric Anholt <eric@anholt.net> - 2017-05-19 22:10 +0200
        Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 22:20 +0200
          Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-23 10:20 +0200
            Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-23 10:40 +0200
              Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Daniel Vetter <daniel@ffwll.ch> - 2017-05-23 15:10 +0200

csiph-web