Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645554
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static |
| Date | 2017-05-19 14:10 +0200 |
| Message-ID | <tIOTf-1TM-5@gated-at.bofh.it> (permalink) |
| References | <tINXc-1jP-13@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Fri, 19 May 2017, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> structure pl111_display_funcs can be made static as it does not need to be
> in global scope. Fixes sparse warning:
>
> "warning: symbol 'pl111_display_funcs' was not declared. Should it
> be static?"
>
> Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms driver for pl111")
The patch looks good and I appreciate what you're doing, but I question
the usefulness of adding Fixes: tags for trivial stuff like this. I'd
prefer Fixes: was reserved for actual fixes that should be backported to
any kernels that have the commit being fixed.
The same applies to many other patches you've sent recently.
BR,
Jani.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/pl111/pl111_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index 39a5c33bce7d..bd8ff82c2fd9 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -280,7 +280,7 @@ static int pl111_display_prepare_fb(struct drm_simple_display_pipe *pipe,
> return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
> }
>
> -const struct drm_simple_display_pipe_funcs pl111_display_funcs = {
> +static const struct drm_simple_display_pipe_funcs pl111_display_funcs = {
> .check = pl111_display_check,
> .enable = pl111_display_enable,
> .disable = pl111_display_disable,
--
Jani Nikula, Intel Open Source Technology Center
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Colin King <colin.king@canonical.com> - 2017-05-19 13:10 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-19 14:10 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Eric Anholt <eric@anholt.net> - 2017-05-19 20:20 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:50 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:50 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Eric Anholt <eric@anholt.net> - 2017-05-19 22:10 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 22:20 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-23 10:20 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-23 10:40 +0200
Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Daniel Vetter <daniel@ffwll.ch> - 2017-05-23 15:10 +0200
csiph-web