Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1645518

[PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static
Date 2017-05-19 13:10 +0200
Message-ID <tINXc-1jP-13@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

structure pl111_display_funcs can be made static as it does not need to be
in global scope.  Fixes sparse warning:

"warning: symbol 'pl111_display_funcs' was not declared. Should it
be static?"

Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/pl111/pl111_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
index 39a5c33bce7d..bd8ff82c2fd9 100644
--- a/drivers/gpu/drm/pl111/pl111_display.c
+++ b/drivers/gpu/drm/pl111/pl111_display.c
@@ -280,7 +280,7 @@ static int pl111_display_prepare_fb(struct drm_simple_display_pipe *pipe,
 	return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
 }
 
-const struct drm_simple_display_pipe_funcs pl111_display_funcs = {
+static const struct drm_simple_display_pipe_funcs pl111_display_funcs = {
 	.check = pl111_display_check,
 	.enable = pl111_display_enable,
 	.disable = pl111_display_disable,
-- 
2.11.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Colin King <colin.king@canonical.com> - 2017-05-19 13:10 +0200
  Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-19 14:10 +0200
    Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Eric Anholt <eric@anholt.net> - 2017-05-19 20:20 +0200
      Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:50 +0200
    Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:50 +0200
      Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Eric Anholt <eric@anholt.net> - 2017-05-19 22:10 +0200
        Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 22:20 +0200
          Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-23 10:20 +0200
            Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-23 10:40 +0200
              Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs  static Daniel Vetter <daniel@ffwll.ch> - 2017-05-23 15:10 +0200

csiph-web