Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644693

Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Thu, 18 May 2017 15:07:02 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Set chain to null after the call to tcf_chain_destroy so that we don't
> call tcf_chain_put on the error exit path, thus avoiding a use-after-free
> error.
> 
> Detected by CoverityScan, CID#1436357 ("Use after free")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Colin, you really need to make some adjustments to how you are submitting
these kinds of patches.

First of all, you must indicate the target tree in your Subject line
as "[PATCH net-next] " in this case.

Also, you need to add an appropriate Fixes: tag right before your
signoff.

Thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: sched: fix a use-after-free error on chain on the error exit path Colin King <colin.king@canonical.com> - 2017-05-18 16:10 +0200
  Re: [PATCH] net: sched: fix a use-after-free error on chain on the  error exit path David Miller <davem@davemloft.net> - 2017-05-18 17:40 +0200
  Re: [PATCH] net: sched: fix a use-after-free error on chain on the  error exit path Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-19 19:20 +0200
    Re: [PATCH] net: sched: fix a use-after-free error on chain on the  error exit path Jiri Pirko <jiri@resnulli.us> - 2017-05-20 09:20 +0200

csiph-web