Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645778

Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path

Show all headers | View raw

On Thu, May 18, 2017 at 7:07 AM, Colin King <colin.king@canonical.com> wrote:
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 4020b8d932a1..82ebdc3fcb2e 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -511,6 +511,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
>         if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) {
>                 tfilter_notify_chain(net, skb, n, chain, RTM_DELTFILTER);
>                 tcf_chain_destroy(chain);


Jiri, how does this work...? An action could hold a refcnt to a filter
chain, but here you destroy a whole chain without respecting
the refcnt???


> +               chain = NULL;
>                 err = 0;
>                 goto errout;

Colin, not your fault, I think we may miss something more serious
when reviewing Jiri's patchset. ;)

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: sched: fix a use-after-free error on chain on the error exit path Colin King <colin.king@canonical.com> - 2017-05-18 16:10 +0200
  Re: [PATCH] net: sched: fix a use-after-free error on chain on the  error exit path David Miller <davem@davemloft.net> - 2017-05-18 17:40 +0200
  Re: [PATCH] net: sched: fix a use-after-free error on chain on the  error exit path Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-19 19:20 +0200
    Re: [PATCH] net: sched: fix a use-after-free error on chain on the  error exit path Jiri Pirko <jiri@resnulli.us> - 2017-05-20 09:20 +0200

csiph-web