Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1644693
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Miller <davem@davemloft.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path |
| Date | Thu, 18 May 2017 17:40:02 +0200 |
| Message-ID | <tIvGW-4Cy-9@gated-at.bofh.it> (permalink) |
| References | <tIuhQ-3NF-11@gated-at.bofh.it> |
| X-Mailer | Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) |
| MIME-Version | 1.0 |
| Content-Type | Text/Plain; charset=us-ascii |
| Content-Transfer-Encoding | 7bit |
| X-Greylist | Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 May 2017 07:49:56 -0700 (PDT) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 23 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 18 May 2017 11:31:26 -0400 (EDT) |
| X-Original-Message-ID | <20170518.113126.77172400948863631.davem@davemloft.net> |
| X-Original-References | <20170518140702.6072-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1644693 |
Show key headers only | View raw
From: Colin King <colin.king@canonical.com>
Date: Thu, 18 May 2017 15:07:02 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Set chain to null after the call to tcf_chain_destroy so that we don't
> call tcf_chain_put on the error exit path, thus avoiding a use-after-free
> error.
>
> Detected by CoverityScan, CID#1436357 ("Use after free")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Colin, you really need to make some adjustments to how you are submitting
these kinds of patches.
First of all, you must indicate the target tree in your Subject line
as "[PATCH net-next] " in this case.
Also, you need to add an appropriate Fixes: tag right before your
signoff.
Thank you.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: sched: fix a use-after-free error on chain on the error exit path Colin King <colin.king@canonical.com> - 2017-05-18 16:10 +0200
Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path David Miller <davem@davemloft.net> - 2017-05-18 17:40 +0200
Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path Cong Wang <xiyou.wangcong@gmail.com> - 2017-05-19 19:20 +0200
Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path Jiri Pirko <jiri@resnulli.us> - 2017-05-20 09:20 +0200
csiph-web