Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil

From	Joel Fernandes <joelaf@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil
Date	2017-05-19 07:00 +0200
Message-ID	<tIIb7-5kI-1@gated-at.bofh.it> (permalink)
References	<tIyv7-6vH-9@gated-at.bofh.it> <tIyv7-6vH-7@gated-at.bofh.it> <tIHRM-5c6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 18, 2017 at 9:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
[..]
>> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
>> index 76877a62b5fa..6915925bc947 100644
>> --- a/kernel/sched/cpufreq_schedutil.c
>> +++ b/kernel/sched/cpufreq_schedutil.c
>> @@ -24,6 +24,7 @@
>>  struct sugov_tunables {
>>         struct gov_attr_set attr_set;
>>         unsigned int rate_limit_us;
>> +       unsigned int iowait_boost_enable;
>
> Maybe just:
>
> bool iowait_boost;

Yes, Rafael mentioned this for the cpufreq framework part, I will do
it this way in v2.

>
>>  };
>>
>>  struct sugov_policy {
>> @@ -47,6 +48,7 @@ struct sugov_policy {
>>         bool work_in_progress;
>>
>>         bool need_freq_update;
>> +       unsigned int iowait_boost_enable;
>
> I don't see this being used at all. Am I missing something ?
>

Ah! Yes you're right, this is spurious, I will drop it. Thanks for spotting it.

-Joel

Thread

[PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-18 20:40 +0200
  Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 03:10 +0200
    Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 03:20 +0200
      Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 06:30 +0200
  Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-19 06:40 +0200
    Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 07:00 +0200
    Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 07:00 +0200

csiph-web