Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644999

Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil

Show all headers | View raw

Hi Rafael,

On Thu, May 18, 2017 at 6:08 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
[..]
>>  static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us);
>> +static struct governor_attr iowait_boost_enable = __ATTR_RW(iowait_boost_enable);
>>
>>  static struct attribute *sugov_attributes[] = {
>>         &rate_limit_us.attr,
>> +       &iowait_boost_enable.attr,
>>         NULL
>>  };
>>
>> @@ -543,6 +574,9 @@ static int sugov_init(struct cpufreq_policy *policy)
>>                         tunables->rate_limit_us *= lat;
>>         }
>>
>> +       if (policy->iowait_boost_enable)
>> +               tunables->iowait_boost_enable = policy->iowait_boost_enable;
>
> Well, that's just
>
> tunables->iowait_boost_enable = policy->iowait_boost_enable;
>
> so I'm not sure about the role of the if ().

Yes you're right, will fix.

>
> Also, do we only need the policy field as an initial value here?
> That's sort of confusing, because intel_pstate does iowait boosting in
> the active mode too and then it is unconditional.
>

I didn't get your comment. Could you clarify what you meant by
'intel_pstate does iowait boosting in the active mode' ? Is there
another path outside the governor where intel_pstate does iowait
boosting, or are you referring to the hardware behavior?

thanks,

-Joel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-18 20:40 +0200
  Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 03:10 +0200
    Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 03:20 +0200
      Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 06:30 +0200
  Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-19 06:40 +0200
    Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 07:00 +0200
    Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 07:00 +0200

csiph-web