Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645199
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Joel Fernandes <joelaf@google.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil |
| Date | Fri, 19 May 2017 07:00:01 +0200 |
| Message-ID | <tIIb7-5kI-1@gated-at.bofh.it> (permalink) |
| References | <tIyv7-6vH-9@gated-at.bofh.it> <tIyv7-6vH-7@gated-at.bofh.it> <tIHRM-5c6-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oW6UfsWGoz0+8oB54Zkb+Qbd/yqB/S66vuVq5CZyMgY=; b=EQdhMWx9ATZiFLgYonWhNAPEBNqaWIIG1Pm6LZMMJKNAYU3+Ifxdi9uHVvC3Z1xwyF q/Syw1Mou+kVqJxtQzWnIW5UXMOxRN3fgmmWhDPg4HkhgW2PhkqxFu5sB9k2TExD0RT7 E8xEgTSootN5ai47lVjuqcaqbml9A3hXZrhsAtMaHCFC4OiYbfzrswijQIHQNgezHBI9 bjF8L7dwGoVb8tlCuA1P31dZfu6I/rP/JGtEQa662n7UaW1WhEFcUVmI99jXbX3r53th /6a64q1RlHiLrxPZfLYojBuKggTu7DWgWyoo6vYmwxwQYLOSkBSrha4R//iEHHHX2uRh Zinw== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oW6UfsWGoz0+8oB54Zkb+Qbd/yqB/S66vuVq5CZyMgY=; b=haUZYYGQ1lUVG9GqDuyCG+ywu+5ieiiMzlgyoljTf+M5eGoCGBEOtltjOVYZmXl+rO Zu2c+UsAt22ebokwCqk9UEbCiAdDZoKiZK6G51ydBtOICYtaQA0CKAJi2e+RJK9pH50E ojwUk/tw9SzqtMjKUQRE07FrRyRPuiQDByfPOYGunnwLjStMZk6dDwsVMIzD4Wa1Xag/ sj3C9c/yvNVEraN4sTWWo5QZQqMTe+3fZJPqB46zXGtRsW3vhXDDMQZpFDhdTUeq3OVP ozDCa6ek7rQu6w8x2Ywd6XNN2AP26cOVO97INDgK1j8jxYiMAftw1qHUfY4lq/mQAIvU w0zQ== |
| X-Gm-Message-State | AODbwcAPedGN/ZpvzK+tT/bWNWBgfOeab0hCo2Zk8oE/kr2GBRS9fkZ7 md4CyFLtN4rcz6spL+lAKCMjAeK1ULk5 |
| X-Received | by 10.176.2.178 with SMTP id 47mr3748695uah.36.1495169960270; Thu, 18 May 2017 21:59:20 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="UTF-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 35 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Peter Zijlstra <peterz@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org> |
| X-Original-Date | Thu, 18 May 2017 21:59:19 -0700 |
| X-Original-Message-ID | <CAJWu+orGGUOiAXUxEaOcUAbBbOE-5Am_DkwfrZBaSN+Qy5kq5g@mail.gmail.com> |
| X-Original-References | <20170518183020.6188-1-joelaf@google.com> <20170518183020.6188-2-joelaf@google.com> <CAOh2x=kHpv7=_YKqMjoVcfBCUyU4QdMsZ7=eb2NQjt4Qyc16-w@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1645199 |
Show key headers only | View raw
On Thu, May 18, 2017 at 9:39 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
[..]
>> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
>> index 76877a62b5fa..6915925bc947 100644
>> --- a/kernel/sched/cpufreq_schedutil.c
>> +++ b/kernel/sched/cpufreq_schedutil.c
>> @@ -24,6 +24,7 @@
>> struct sugov_tunables {
>> struct gov_attr_set attr_set;
>> unsigned int rate_limit_us;
>> + unsigned int iowait_boost_enable;
>
> Maybe just:
>
> bool iowait_boost;
Yes, Rafael mentioned this for the cpufreq framework part, I will do
it this way in v2.
>
>> };
>>
>> struct sugov_policy {
>> @@ -47,6 +48,7 @@ struct sugov_policy {
>> bool work_in_progress;
>>
>> bool need_freq_update;
>> + unsigned int iowait_boost_enable;
>
> I don't see this being used at all. Am I missing something ?
>
Ah! Yes you're right, this is spurious, I will drop it. Thanks for spotting it.
-Joel
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-18 20:40 +0200
Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 03:10 +0200
Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 03:20 +0200
Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-19 06:30 +0200
Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-19 06:40 +0200
Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 07:00 +0200
Re: [PATCH 2/2] sched: Use iowait boost policy option in schedutil Joel Fernandes <joelaf@google.com> - 2017-05-19 07:00 +0200
csiph-web