Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641441

[PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

c04fc586c1a4 ("mm: show node to memory section relationship with
symlinks in sysfs") has added means to export memblock<->node
association into the sysfs. It has also introduced get_nid_for_pfn
which is a rather confusing counterpart of pfn_to_nid which checks also
whether the pfn page is already initialized (page_initialized).  This
is done by checking page::lru != NULL which doesn't make any sense at
all. Nothing in this path really relies on the lru list being used or
initialized. Just remove it because this will become a problem with
later patches.

Thanks to Reza Arbab for testing which revealed this to be a problem
(http://lkml.kernel.org/r/20170403202337.GA12482@dhcp22.suse.cz)

Acked-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 drivers/base/node.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index 5548f9686016..06294d69779b 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -368,21 +368,14 @@ int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)
 }
 
 #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
-#define page_initialized(page)  (page->lru.next)
-
 static int __ref get_nid_for_pfn(unsigned long pfn)
 {
-	struct page *page;
-
 	if (!pfn_valid_within(pfn))
 		return -1;
 #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
 	if (system_state == SYSTEM_BOOTING)
 		return early_pfn_to_nid(pfn);
 #endif
-	page = pfn_to_page(pfn);
-	if (!page_initialized(page))
-		return -1;
 	return pfn_to_nid(pfn);
 }
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -v4 0/14] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:00 +0200
  [PATCH 07/14] mm: consider zone which is not fully populated to have holes Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-05-18 18:20 +0200
      Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Michal Hocko <mhocko@kernel.org> - 2017-05-18 18:50 +0200
        Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 09:30 +0200
  [PATCH 09/14] mm: __first_valid_page skip over offline pages Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 09/14] mm: __first_valid_page skip over offline pages Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 10:10 +0200
  [PATCH 14/14] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 12/14] mm, memory_hotplug: replace for_device by want_memblock in arch_add_memory Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 08/14] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 08/14] mm, compaction: skip over holes in  __reset_isolation_suitable Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 09:30 +0200
  [PATCH 10/14] mm, vmstat: skip reporting offline pages in pagetypeinfo Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 10/14] mm, vmstat: skip reporting offline pages in  pagetypeinfo Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 10:20 +0200
  [PATCH 05/14] mm, memory_hotplug: split up register_one_node Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded  memory to zones until online Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 11:00 +0200
  [PATCH 06/14] mm, memory_hotplug: consider offline memblocks removable Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 13/14] mm, memory_hotplug: fix the section mismatch warning Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200

csiph-web