Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641431

[PATCH 10/14] mm, vmstat: skip reporting offline pages in pagetypeinfo

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

pagetypeinfo_showblockcount_print skips over invalid pfns but it would
report pages which are offline because those have a valid pfn. Their
migrate type is misleading at best. Now that we have pfn_to_online_page()
we can use it instead of pfn_valid() and fix this.

Noticed-by: Joonsoo Kim <js1304@gmail.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 mm/vmstat.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 571d3ec05566..c432e581f9a9 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1223,11 +1223,9 @@ static void pagetypeinfo_showblockcount_print(struct seq_file *m,
 	for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
 		struct page *page;
 
-		if (!pfn_valid(pfn))
+		if (!pfn_to_online_page(pfn))
 			continue;
 
-		page = pfn_to_page(pfn);
-
 		/* Watch for unexpected holes punched in the memmap */
 		if (!memmap_valid_within(pfn, page, zone))
 			continue;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v4 0/14] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:00 +0200
  [PATCH 07/14] mm: consider zone which is not fully populated to have holes Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-05-18 18:20 +0200
      Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Michal Hocko <mhocko@kernel.org> - 2017-05-18 18:50 +0200
        Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 09:30 +0200
  [PATCH 09/14] mm: __first_valid_page skip over offline pages Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 09/14] mm: __first_valid_page skip over offline pages Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 10:10 +0200
  [PATCH 14/14] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 12/14] mm, memory_hotplug: replace for_device by want_memblock in arch_add_memory Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 08/14] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 08/14] mm, compaction: skip over holes in  __reset_isolation_suitable Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 09:30 +0200
  [PATCH 10/14] mm, vmstat: skip reporting offline pages in pagetypeinfo Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 10/14] mm, vmstat: skip reporting offline pages in  pagetypeinfo Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 10:20 +0200
  [PATCH 05/14] mm, memory_hotplug: split up register_one_node Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded  memory to zones until online Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 11:00 +0200
  [PATCH 06/14] mm, memory_hotplug: consider offline memblocks removable Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 13/14] mm, memory_hotplug: fix the section mismatch warning Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200

csiph-web