Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641436

[PATCH 06/14] mm, memory_hotplug: consider offline memblocks removable

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

is_pageblock_removable_nolock relies on having zone association to
examine all the page blocks to check whether they are movable or free.
This is just wasting of cycles when the memblock is offline. Later patch
in the series will also change the time when the page is associated with
a zone so we let's bail out early if the memblock is offline.

Reported-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 drivers/base/memory.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index f8fd562c3f18..1e884d82af6f 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -128,6 +128,9 @@ static ssize_t show_mem_removable(struct device *dev,
 	int ret = 1;
 	struct memory_block *mem = to_memory_block(dev);
 
+	if (mem->state != MEM_ONLINE)
+		goto out;
+
 	for (i = 0; i < sections_per_block; i++) {
 		if (!present_section_nr(mem->start_section_nr + i))
 			continue;
@@ -135,6 +138,7 @@ static ssize_t show_mem_removable(struct device *dev,
 		ret &= is_mem_section_removable(pfn, PAGES_PER_SECTION);
 	}
 
+out:
 	return sprintf(buf, "%d\n", ret);
 }
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -v4 0/14] mm: make movable onlining suck less Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:00 +0200
  [PATCH 07/14] mm: consider zone which is not fully populated to have holes Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-05-18 18:20 +0200
      Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Michal Hocko <mhocko@kernel.org> - 2017-05-18 18:50 +0200
        Re: [PATCH 07/14] mm: consider zone which is not fully populated to  have holes Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 09:30 +0200
  [PATCH 09/14] mm: __first_valid_page skip over offline pages Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 09/14] mm: __first_valid_page skip over offline pages Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 10:10 +0200
  [PATCH 14/14] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 12/14] mm, memory_hotplug: replace for_device by want_memblock in arch_add_memory Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 08/14] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 08/14] mm, compaction: skip over holes in  __reset_isolation_suitable Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 09:30 +0200
  [PATCH 10/14] mm, vmstat: skip reporting offline pages in pagetypeinfo Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 10/14] mm, vmstat: skip reporting offline pages in  pagetypeinfo Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 10:20 +0200
  [PATCH 05/14] mm, memory_hotplug: split up register_one_node Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
    Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded  memory to zones until online Vlastimil Babka <vbabka@suse.cz> - 2017-05-19 11:00 +0200
  [PATCH 06/14] mm, memory_hotplug: consider offline memblocks removable Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 13/14] mm, memory_hotplug: fix the section mismatch warning Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200
  [PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko <mhocko@kernel.org> - 2017-05-15 11:10 +0200

csiph-web