Re: Question on fscrypt_d_revalidate() and fstest generic/429

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: Question on fscrypt_d_revalidate() and fstest generic/429
Date	2017-05-17 00:30 +0200
Message-ID	<tHT8D-3a6-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <tHuad-3U0-5@gated-at.bofh.it> <tHujU-3Xr-23@gated-at.bofh.it> <tHxB8-6e6-9@gated-at.bofh.it> <tHEsW-28N-11@gated-at.bofh.it> <tHSPh-31N-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Eric,

Am 17.05.2017 um 00:07 schrieb Eric Biggers:
>>> I can reproduce this on an unencrypted directory after updating path_init() in
>>> fs/namei.c to always clear LOOKUP_RCU, so that all path lookups are done in
>>> ref-walk mode.  So I think fscrypt_d_revalidate() was only relevant because it
>>> causes all path lookups to drop out of rcu-walk mode.
>>
>> On ext4 or UBIFS?
>
> Both; the inode "leak" isn't filesystem-specific, beyond the fact that UBIFS
> apparently limits the number of inodes on its orphan list while ext4 does not.
> (How do I know it happens on ext4 then?  /proc/slabinfo shows that lots of ext4
> inodes have been allocated, and after an unclean shutdown and remounting, it's
> reported that 50,000+ orphan inodes were deleted.)

UBIFS's orphan list is limited by the size of a LEB (logical erase block).
With nandsim's default settings such a LEB is rather small and can store only
2k orphans.

> There are lots of cases in which path lookups switch from rcu-walk mode into
> ref-walk mode, so the fact that it was being caused by ->d_revalidate() in this
> specific situation isn't really important, IMO.
> 
> I think the actual fix would be something along the lines of making vfs_rmdir()
> unhash any negative child dentries, so that they get "killed" by dput() later.

Thanks,
//richard

Thread

Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-15 16:40 +0200
  Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-15 21:50 +0200
    Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-15 22:00 +0200
      Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-16 01:30 +0200
        Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-16 08:50 +0200
          Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-17 00:10 +0200
            Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-17 00:30 +0200
      Re: Question on fscrypt_d_revalidate() and fstest generic/429 Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-16 02:00 +0200
        Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-16 13:30 +0200

csiph-web