Re: Question on fscrypt_d_revalidate() and fstest generic/429

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: Question on fscrypt_d_revalidate() and fstest generic/429
Date	2017-05-16 08:50 +0200
Message-ID	<tHEsW-28N-11@gated-at.bofh.it> (permalink)
References	<tHpke-Uz-5@gated-at.bofh.it> <tHuad-3U0-5@gated-at.bofh.it> <tHujU-3Xr-23@gated-at.bofh.it> <tHxB8-6e6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Eric,

Am 16.05.2017 um 01:25 schrieb Eric Biggers:
> On Mon, May 15, 2017 at 09:51:03PM +0200, Richard Weinberger wrote:
>>>
>>> The test is repeatedly creating and removing a directory "dir" while lookups are
>>> being done in it.  It seems the problem is that many dentries are being created
>>> for "dir", and they pin many different inodes, all at the same time.  This
>>> actually happens for ext4 too; it just doesn't cause an observable error.
>>>
>>> I doubt it's the right solution to make fscrypt_d_revalidate() look at
>>> ->i_nlink, since ->d_revalidate() is meant to validate the filename, not the
>>> inode.  I think there is probably a VFS bug that is causing the dentries to not
>>> be freed.
>>
>> Not sure. Al? :-)
>>
> 
> I can reproduce this on an unencrypted directory after updating path_init() in
> fs/namei.c to always clear LOOKUP_RCU, so that all path lookups are done in
> ref-walk mode.  So I think fscrypt_d_revalidate() was only relevant because it
> causes all path lookups to drop out of rcu-walk mode.

On ext4 or UBIFS?

Thanks,
//richard

Thread

Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-15 16:40 +0200
  Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-15 21:50 +0200
    Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-15 22:00 +0200
      Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-16 01:30 +0200
        Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-16 08:50 +0200
          Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-17 00:10 +0200
            Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-17 00:30 +0200
      Re: Question on fscrypt_d_revalidate() and fstest generic/429 Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-16 02:00 +0200
        Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-16 13:30 +0200

csiph-web