Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642133

Re: Question on fscrypt_d_revalidate() and fstest generic/429

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: Question on fscrypt_d_revalidate() and fstest generic/429
Date 2017-05-16 02:00 +0200
Message-ID <tHy49-6nt-9@gated-at.bofh.it> (permalink)
References <tHpke-Uz-5@gated-at.bofh.it> <tHuad-3U0-5@gated-at.bofh.it> <tHujU-3Xr-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, May 15, 2017 at 09:51:03PM +0200, Richard Weinberger wrote:

> > I doubt it's the right solution to make fscrypt_d_revalidate() look at
> > ->i_nlink, since ->d_revalidate() is meant to validate the filename, not the
> > inode.  I think there is probably a VFS bug that is causing the dentries to not
> > be freed.
> 
> Not sure. Al? :-)

What's to tell VFS that they are garbage?  If your code doesn't do it,
VFS has no way to know.  And I certainly agree that using ->d_revalidate()
to trigger their unhashing is a bloody odd design; take it up with whoever
had come up with it...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-15 16:40 +0200
  Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-15 21:50 +0200
    Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-15 22:00 +0200
      Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-16 01:30 +0200
        Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-16 08:50 +0200
          Re: Question on fscrypt_d_revalidate() and fstest generic/429 Eric Biggers <ebiggers3@gmail.com> - 2017-05-17 00:10 +0200
            Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-17 00:30 +0200
      Re: Question on fscrypt_d_revalidate() and fstest generic/429 Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-16 02:00 +0200
        Re: Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger <richard@nod.at> - 2017-05-16 13:30 +0200

csiph-web