Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1638063

[PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp()
Date 2017-05-09 14:00 +0200
Message-ID <tFbY5-1dU-9@gated-at.bofh.it> (permalink)
References <tFbY5-1dU-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 13:36:04 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 4fa95234978c..9ab4cbfa67f1 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -445,8 +445,6 @@ static void stmmac_get_tx_hwtstamp(struct stmmac_priv *priv,
 		/* pass tstamp to stack */
 		skb_tstamp_tx(skb, &shhwtstamp);
 	}
-
-	return;
 }
 
 /* stmmac_get_rx_hwtstamp - get HW RX timestamps
-- 
2.12.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] net: stmmac: Fine-tuning for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a  seq_puts() in stmmac_sysfs_dma_cap_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in  stmmac_get_tx_hwtstamp() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function  implementations Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-05-10 09:00 +0200

csiph-web