Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638062
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() |
| Date | 2017-05-09 14:00 +0200 |
| Message-ID | <tFbY5-1dU-7@gated-at.bofh.it> (permalink) |
| References | <tFbY5-1dU-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 9 May 2017 13:10:28 +0200 A bit of text was put into a sequence by three separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index cd8c60132390..2949c9fc18fa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3802,10 +3802,10 @@ static int stmmac_sysfs_dma_cap_read(struct seq_file *seq, void *v) return 0; } - seq_printf(seq, "==============================\n"); - seq_printf(seq, "\tDMA HW features\n"); - seq_printf(seq, "==============================\n"); - + seq_puts(seq, + "==============================\n" + "\tDMA HW features\n" + "==============================\n"); seq_printf(seq, "\t10/100 Mbps: %s\n", (priv->dma_cap.mbps_10_100) ? "Y" : "N"); seq_printf(seq, "\t1000 Mbps: %s\n", -- 2.12.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] net: stmmac: Fine-tuning for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200 [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a seq_puts() in stmmac_sysfs_dma_cap_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200 [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200 [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200 Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-05-10 09:00 +0200
csiph-web