Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1638063

[PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp()

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in stmmac_get_tx_hwtstamp()
Date Tue, 09 May 2017 14:00:01 +0200
Message-ID <tFbY5-1dU-9@gated-at.bofh.it> (permalink)
References <tFbY5-1dU-5@gated-at.bofh.it>
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Language en-US
Content-Transfer-Encoding 7bit
X-Provags-ID V03:K0:THAOnmdomZtfp65sZiG9iFgOaFVacXLuRa7PBkHaz6/+BXKTDiv YaHSk82QwPxoVyIVO+GIO3KiJrCubY7PX5qmNbJKnmLMw24mgXSBI+83I9S0bM9WVBZY6E8 IKieM2HAA2TIM8xkOwuLRFhO6f5TdQ84hepbGS40mRIRNIYNN1Cbsq7xt39T4D9vPNVRdLn JbscMdAWj59mjcfxop6wA==
X-Ui-Out-Filterresults notjunk:1;V01:K0:ytmeg6fhrGk=:hpF60A4GciL3gEYCtbQTXe 37qQ29wPfFBRqijHbR+FHm9amr4QH08FFKeomkDmvxS5DTZDDIJpcmiYXz2TjKdfP938k9hY2 qW2hMWXUtfrhVPALhlYcYDh1go4kPA9eeelTiwN4iuSpUjveVLQfe+tYv/6QnzHF5duZIEkXY 6KdJNdrtiTHn6XgTLORaQNFAsI7QXB6itRPZS4QP6pfGjIqoadrf4E/xFMQ18m6do225Yx5bx 1p+biuvloF24yuO8NzsdnkLe6HDEuK5/QA4LWdVR4lQxL7TLpToD5epYzLcUDaj7mTnLFC8Q3 vbgNePpR2Cvt2loT5/b6DtOxY2SjNyBFdFLglko2ab+jTNFvurQ0mCciJtRA7bFAX14o4Xzcq HlH9VE9lGmoFnY3LWinmPfHVu1pSXFKnaZM+B3+KeiPWTtcbX5ldnrKf2GVbK+Qy3jAYm343Y EqKqt93uQyOXQ8tsWnrI2Jk6VesoRzav5i2JUMuZKsywqS7s69AwwjEypfQhPDwwUOSPwJFAo 0JvbCXzmluVaQtemlxf7sQl8Xav/qgI41TIA7SeSETukpy+Ldr3ImXmPXaY/CFclFDrCpYwaN EIdNh9sE2ud3SrPkDBjtrqfl0tlbSH8vC1PzP6YaQuei1M3kr4f+Hij8ckV+wVfmW0c2eLazD HJoP+BvX7QpcuGsMIi5tCJBpHDhH/cgdt+KO8IX0uTBAUQfspKRCXAHRAj3YFELAAKDCcnSkk R2mZuW2+ZW2R3qY9qaiiMpiMjKyUbTwJxBHey9q6697/GXrvGLHTknOMZt0iz0AHcgiM0Za0S ZiPa+b7
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date Tue, 9 May 2017 13:55:35 +0200
X-Original-Message-ID <4d8b60f5-5d5f-8fa1-a896-d48c2b054ec4@users.sourceforge.net>
X-Original-References <aa58027a-a39c-963e-4376-a4d5312ee118@users.sourceforge.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1638063

Show key headers only | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 13:36:04 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 4fa95234978c..9ab4cbfa67f1 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -445,8 +445,6 @@ static void stmmac_get_tx_hwtstamp(struct stmmac_priv *priv,
 		/* pass tstamp to stack */
 		skb_tstamp_tx(skb, &shhwtstamp);
 	}
-
-	return;
 }
 
 /* stmmac_get_rx_hwtstamp - get HW RX timestamps
-- 
2.12.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] net: stmmac: Fine-tuning for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  [PATCH 1/4] net: stmmac: Combine three seq_printf() calls into a  seq_puts() in stmmac_sysfs_dma_cap_read() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  [PATCH 4/4] net: stmmac: Delete an unnecessary return statement in  stmmac_get_tx_hwtstamp() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  [PATCH 3/4] net: stmmac: Use seq_putc() in sysfs_display_ring() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 14:00 +0200
  Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function  implementations Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-05-10 09:00 +0200

csiph-web