Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure
Date	2017-05-11 17:10 +0200
Message-ID	<tFXT3-7X6-9@gated-at.bofh.it> (permalink)
References	<tFVey-6c7-21@gated-at.bofh.it> <tFWX0-7l8-29@gated-at.bofh.it> <tFXq2-7wN-15@gated-at.bofh.it> <tFXq2-7wN-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 11, 2017 at 4:37 PM, Mintz, Yuval <Yuval.Mintz@cavium.com> wrote:
>> > For the most part - I'm almost all in favor of this change.
>> > But just to make it clear - the actual fix could have been a one-liner, right?
>> > The rest are style changes.
>
>> Correct. Having the correct length in the memset is a sufficient fix for the warning,
>> but it felt wrong to send it since the root of the problem seems to be the
>> complexity of the code that was hiding it.
>
> ...
>
>> Generally speaking, feel free to treat any of my compile-time warning fix
>> patches as simple bug reports and apply a different fix that seems more
>> appropriate. I mainly send it in patch form since that seems to be the
>> quickest way to address any issues.
>
> Sure.
>
> Once net-next is re-opened I intend to push our next FW version which
> is also going to change some of the aRFS related configurations.
>
> So I think we should stick to the single-liner fix for now,
> and I'll revise the style [if still needed; I'll have to check] on that submission.

Sounds good, thanks!

     Arnd

Thread

[PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:20 +0200
  RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-05-11 16:10 +0200
    RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-05-11 16:40 +0200
      Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 17:10 +0200
    Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 16:40 +0200

csiph-web