Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639597

RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure

Show all headers | View raw

> > For the most part - I'm almost all in favor of this change.
> > But just to make it clear - the actual fix could have been a one-liner, right?
> > The rest are style changes.

> Correct. Having the correct length in the memset is a sufficient fix for the warning,
> but it felt wrong to send it since the root of the problem seems to be the
> complexity of the code that was hiding it.

...

> Generally speaking, feel free to treat any of my compile-time warning fix
> patches as simple bug reports and apply a different fix that seems more
> appropriate. I mainly send it in patch form since that seems to be the
> quickest way to address any issues.

Sure. 

Once net-next is re-opened I intend to push our next FW version which
is also going to change some of the aRFS related configurations.

So I think we should stick to the single-liner fix for now,
and I'll revise the style [if still needed; I'll have to check] on that submission.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:20 +0200
  RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-05-11 16:10 +0200
    RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-05-11 16:40 +0200
      Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 17:10 +0200
    Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 16:40 +0200

csiph-web