Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639485

RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure

Show all headers | View raw

> register, which went subtly wrong due to the wrong size in a memset():
> 
> ethernet/qlogic/qed/qed_init_fw_funcs.c: In function
> 'qed_set_rfs_mode_disable':
> ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void
> *)&ramline+4)' is used uninitialized in this function [-Werror=uninitialized]
> 
> This removes the silly loop and memset, and instead directly writes the
> correct value to the register.

Hi Arnd,

For the most part - I'm almost all in favor of this change.
But just to make it clear - the actual fix could have been a one-liner, right?
The rest are style changes.

> +#define CAM_REG(pf_id) (PRS_REG_GFT_CAM + CAM_LINE_SIZE * (pf_id))
> +#define RAM_REG(pf_id) (PRS_REG_GFT_PROFILE_MASK_RAM +

Not sure I'm a huge fan of this specific style change;
Seems like we could easily manage without these macros.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:20 +0200
  RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-05-11 16:10 +0200
    RE: [PATCH] qed: fix uninitialized data in aRFS intrastructure "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-05-11 16:40 +0200
      Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 17:10 +0200
    Re: [PATCH] qed: fix uninitialized data in aRFS intrastructure Arnd Bergmann <arnd@arndb.de> - 2017-05-11 16:40 +0200

csiph-web